[mvapich-discuss] Wrong MPI_Win_allocate calls in OSU benchmark

[Bert Wesarg]

Dear all,

I needed to revisit this, because valgrind showed me invalid reads/writes and also memory leaks. I come up with the attached second version of the patch.

Please review.

Best,
Bert

On 18.06.20 09:41, Bert Wesarg wrote:
> Dear all,
> 
> while using the OSU benchmark, I noticed that the `baseptr` parameter was wrongly assigned in the calls to `MPI_Win_allocate`. This parameter is marked as an OUT parameter and thus should be a pointer to a pointer. Just like `MPI_Mem_alloc`.
> 
> Please find attached a diff against 5.6.3. The additional changes in mpi/one-sided/osu_get_acc_latency.c are due to the fact, that `rbuf` is not passed as reference to `allocate_memory_get_acc_lat` and this parameter shadows the global one.
> 
> Best,
> Bert
> 

-- 
Dipl.-Inf. Bert Wesarg
wiss. Mitarbeiter

Technische Universität Dresden
Zentrum für Informationsdienste und Hochleistungsrechnen (ZIH)
01062 Dresden

📞 +49 (351) 463-42451
📠 +49 (351) 463-37773
📧 bert.wesarg at tu-dresden.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osu-micro-benchmarks-5.6.3.win-alloc.2.patch
Type: text/x-patch
Size: 4434 bytes
Desc: not available
URL: <http://mailman.cse.ohio-state.edu/pipermail/mvapich-discuss/attachments/20200619/dee791dd/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5244 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mailman.cse.ohio-state.edu/pipermail/mvapich-discuss/attachments/20200619/dee791dd/attachment-0001.p7s>