[mvapich-discuss] Perhaps small bug/fix found for mvapich-1.0-beta
Alexei I. Adamovich
lexa at adam.botik.ru
Tue Dec 11 09:57:42 EST 2007
Hi!
Seems, I've found a small cut-an-paste-style inexactness in
mpid/ch_gen2_us/mv_buf.c (in get_rbuf_size), see diff/patch in attachement.
Is this one known already?
Sincerely,
Alexei I. Adamovich
-------------- next part --------------
--- mpid/ch_gen2_ud/mv_buf.c 2007-10-26 23:50:29.000000000 +0400
+++ /tmp/mv_buf.c 2007-12-11 16:06:46.000000000 +0300
@@ -100,31 +100,31 @@
static inline mv_rbuf_size * get_rbuf_size(int rbuf_size) {
int found = 0, i;
mv_rbuf_size * b;
for(i = 0; i < mv_rbuf_avail_num; i++) {
if(mv_rbuf_avail[i].alloc_size == rbuf_size) {
found = 1;
b = &(mv_rbuf_avail[i]);
break;
}
}
if(!found) {
/* TODO: re-order based on size!!! */
- b = &(mv_rbuf_avail[mv_sbuf_avail_num]);
+ b = &(mv_rbuf_avail[mv_rbuf_avail_num]);
b->alloc_size = rbuf_size;
/* TODO: change if using headers */
b->max_data_size = rbuf_size;
b->head = NULL;
mv_rbuf_avail_num++;
D_PRINT("creating new rbuf size: %d\n", rbuf_size);
}
return b;
}
More information about the mvapich-discuss
mailing list